devindata-public
/
csi-driver-nfs
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

<carry>: Disable unit tests due to carry patch 

Disable unit tests which fail and have no direct replacement due to
carry patch 59fe400d43.
This commit is contained in:
Matthew Booth 2021-06-17 17:43:10 +01:00
parent a7f5765049
commit 69a6678bfd
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/nfs/nodeserver_test.go
View File

@ -133,7 +133,7 @@ func TestNodeUnpublishVolume(t *testing.T) {
errorTarget := testutil.GetWorkDirPath("error_is_likely_target", t) errorTarget := testutil.GetWorkDirPath("error_is_likely_target", t)
targetTest := testutil.GetWorkDirPath("target_test", t) targetTest := testutil.GetWorkDirPath("target_test", t)
targetFile := testutil.GetWorkDirPath("abc.go", t) //targetFile := testutil.GetWorkDirPath("abc.go", t)
tests := []struct { tests := []struct {
desc string desc string
@ -152,16 +152,20 @@ func TestNodeUnpublishVolume(t *testing.T) {
req: csi.NodeUnpublishVolumeRequest{VolumeId: "vol_1"}, req: csi.NodeUnpublishVolumeRequest{VolumeId: "vol_1"},
expectedErr: status.Error(codes.InvalidArgument, "Target path missing in request"), expectedErr: status.Error(codes.InvalidArgument, "Target path missing in request"),
}, },
/* Not relevant due to carry patch https://github.com/openshift/csi-driver-nfs/commit/59fe400d433137c48de81650026922a88e167177
// Downstream doesn't call IsLikelyNotMountPoint, and doesn't raise any error if the target is not mounted
{ {
desc: "[Error] Unmount error mocked by IsLikelyNotMountPoint", desc: "[Error] Unmount error mocked by IsLikelyNotMountPoint",
req: csi.NodeUnpublishVolumeRequest{TargetPath: errorTarget, VolumeId: "vol_1"}, req: csi.NodeUnpublishVolumeRequest{TargetPath: errorTarget, VolumeId: "vol_1"},
expectedErr: status.Error(codes.Internal, "fake IsLikelyNotMountPoint: fake error"), expectedErr: status.Error(codes.Internal, "fake IsLikelyNotMountPoint: fake error"),
}, },
// Downstream doesn't raise any error if the target is not mounted
{ {
desc: "[Error] Volume not mounted", desc: "[Error] Volume not mounted",
req: csi.NodeUnpublishVolumeRequest{TargetPath: targetFile, VolumeId: "vol_1"}, req: csi.NodeUnpublishVolumeRequest{TargetPath: targetFile, VolumeId: "vol_1"},
expectedErr: status.Error(codes.NotFound, "Volume not mounted"), expectedErr: status.Error(codes.NotFound, "Volume not mounted"),
}, },
*/
} }
// Setup // Setup